KarmaGYZ commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388693078
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ActiveResourceManagerFactory.java
##########
@@ -81,4 +83,14 @@ private static Configuration
createActiveResourceManagerConfiguration(Configurat
ClusterInformation clusterInformation,
@Nullable String webInterfaceUrl,
ResourceManagerMetricGroup resourceManagerMetricGroup) throws
Exception;
+
+ protected WorkerResourceSpec
createDefaultWorkerResourceSpec(Configuration configuration) {
Review comment:
If I understand it correctly, SM, instead of RM, should take care of the
`WorkerResourceSpec`. Meanwhile, only static SM needs a default
`WorkerResourceSpec`. If that is the case, I prefer to move this logic inside
the current `SlotManagerImpl`. This may also prevent getting the default CPU
cores in ResourceManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
