TisonKun commented on a change in pull request #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386301412
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
Unfortunately after I change `CHAR` to `VARCHAR` the test cases `'[]'` and
so on failed with mismatch. Thus I manually add `CHAR` *and* `VARCHAR` in
`FunctionGenerator`. I agree that we can do follow-ups to ease the overhead of
combinations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
