JingsongLi commented on a change in pull request #11273:
[FLINK-12814][sql-client] Support tableau result format
URL: https://github.com/apache/flink/pull/11273#discussion_r386242695
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -512,21 +512,38 @@ private void callSelect(SqlCommandCall cmdCall) {
printExecutionException(e);
return;
}
- final CliResultView view;
- if (resultDesc.isMaterialized()) {
- view = new CliTableResultView(this, resultDesc);
+
+ if (resultDesc.isTableauMode()) {
+ CliTableauResultView tableauResultView = new
CliTableauResultView(
+ terminal, executor, sessionId,
resultDesc);
+ try {
Review comment:
try with resource management?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
