wuchong commented on a change in pull request #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386220827
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
`FunctionGenerator` is not perfect now, we may need to declare different
combinations of types. We will improve that in the future. But I think
`VARCHAR` can suite both for CHAR and VARCHAR here. So let's reduce the
combinations here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
