KarmaGYZ commented on a change in pull request #11248: [FLINK-16299] Release
containers recovered from previous attempt in w…
URL: https://github.com/apache/flink/pull/11248#discussion_r386073340
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -222,6 +222,10 @@ MainThreadExecutor getMainThreadExecutorForTesting() {
return super.getMainThreadExecutor();
}
+ void setTestingNMClientAsync(TestingNMClientAsync
testingNMClientAsync) {
+ this.testingNMClientAsync = testingNMClientAsync;
+ }
Review comment:
Agreed. We can leverage `CompletableFuture`.
Regarding creating `TestingNMClientAsync` in `Context`, we need to create a
`TestingYarnResourceManager` first and then pass it as the `callBackHandler` to
the constructor of `TestingNMClientAsync`.
So, I prefer to create `TestingNMClientAsync` in the constructor of
`TestingYarnResourceManager` and add a "getter" function in
`TestingYarnResourceManager`. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
