[
https://issues.apache.org/jira/browse/FLINK-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047377#comment-17047377
]
Igal Shilman commented on FLINK-16274:
--------------------------------------
Hi [~tzulitai],
After giving more thought to it , it seems like this is a useful feature to add
to the e2e test framework, and it is worth
the tradeoff (of a reduced e2e test coverage) for developer productivity.
Let me, for the sake of completeness explain what I meant:
To my understanding the intended usage of:
{code:java}
.withConfiguration(ConfigOption<T> option, T value);
{code}
Is to provide directly a config option reference, then lets say for example, we
have an e2e test that calls this:
{code:java}
.withConfiguration(org.apache.flink.configuration.CoreOptions.CLASSLOADER_RESOLVE_ORDER,
..)
{code}
And at some point, This ConfigOption is being renamed or deprecated and
replaced by some other config value.
Then this e2e test would still pass, because on both ends we would use the same
reference.
But on the other hand, imagine that the e2e test had a flink-conf.yaml with
{code:java}
"classloader.resolve-order: child"
{code}
Then the e2e test would fail (hopefully) because on the reading side (operator)
we would try to obtain the new key name and we will
not find it.
> Add typed builder methods for setting dynamic configuration on
> StatefulFunctionsAppContainers
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-16274
> URL: https://issues.apache.org/jira/browse/FLINK-16274
> Project: Flink
> Issue Type: New Feature
> Components: Stateful Functions, Test Infrastructure
> Affects Versions: statefun-1.1
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Excerpt from:
> https://github.com/apache/flink-statefun/pull/32#discussion_r383644382
> Currently, you'd need to provide a complete {{Configuration}} as dynamic
> properties when constructing a {{StatefulFunctionsAppContainers}}.
> It'll be nicer if this is built like this:
> {code}
> public StatefulFunctionsAppContainers verificationApp =
> new StatefulFunctionsAppContainers("sanity-verification", 2)
> .withModuleGlobalConfiguration("kafka-broker",
> kafka.getBootstrapServers())
> .withConfiguration(ConfigOption option, configValue)
> {code}
> And by default the {{StatefulFunctionsAppContainers}} just only has the
> configs in the base template {{flink-conf.yaml}}.
> This would require lazy construction of the containers on {{beforeTest}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
