zhijiangW commented on a change in pull request #7368: [FLINK-10742][network]
Let Netty use Flink's buffers directly in credit-based mode
URL: https://github.com/apache/flink/pull/7368#discussion_r385518513
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageClientSideSerializationTest.java
##########
@@ -183,15 +192,18 @@ private void testEncodeDecodeBuffer(boolean
testReadOnlyBuffer, boolean testComp
}
NettyMessage.BufferResponse expected = new
NettyMessage.BufferResponse(
- testBuffer, random.nextInt(), new InputChannelID(),
random.nextInt());
- NettyMessage.BufferResponse actual = encodeAndDecode(expected);
+ testBuffer, random.nextInt(),
inputChannel.getInputChannelId(), random.nextInt());
+ NettyMessage.BufferResponse actual = encodeAndDecode(expected,
channel);
// Netty 4.1 is not copying the messages, but retaining slices
of them. BufferResponse actual is in this case
Review comment:
This comment is not invalid now? because we do not use previous
`LengthFieldBasedFrameDecoder`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
