wsry opened a new pull request #11155: [FLINK-14818] Fix receiving InputGate 
setup of StreamNetworkBenchmarkEnvironment.
URL: https://github.com/apache/flink/pull/11155
 
 
   ## What is the purpose of the change
   
   In network benchmark (for example 1000 channels benchmark with 4 record 
writers) StreamNetworkBenchmarkEnvironment#createInputGate creates 1000 input 
gates with 4 input channels each, which doesn't make much sense. It is expected 
that either having 4 receivers with single input gate with 1000 channels each, 
or a single receiver with 4 input gates, with 1000 channels each.
   
   
   ## Brief change log
   
     - The receiving InputGate setup logic of StreamNetworkBenchmarkEnvironment 
is changed
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
StreamNetworkThroughputBenchmarkTest.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to