zhijiangW commented on a change in pull request #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#discussion_r381770789
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/BufferResponseDecoderDelegate.java ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.netty; + +import org.apache.flink.runtime.io.network.NetworkClientHandler; +import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf; +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext; + +import static org.apache.flink.runtime.io.network.netty.NettyMessage.BufferResponse; + +/** + * The parser for {@link org.apache.flink.runtime.io.network.netty.NettyMessage.BufferResponse}. + */ +public class BufferResponseDecoderDelegate implements NettyMessageDecoderDelegate { Review comment: After thinking through, it is necessary to redefine the function of `BufferResponseDecoderDelegate`. Currently it is not only decoding from `ByteBuf` to `BufferResponse` message, and also involving in the specific cases for `size = 0` and `released channel`, which would make the internal logics more complex. Instead we can make `BufferResponseDecoderDelegate` only handle the decoder work, and fire the complete `BufferResponse` message to next `PartitionRequestClientHandler` which would handle the specific logics more easily and clean. I would point out the related changes in detail codes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
