StephanEwen opened a new pull request #11095: [FLINK-10918][rocks-db-backend] Fix incremental checkpoints on Windows. URL: https://github.com/apache/flink/pull/11095 ## What is the purpose of the change This solves the bug that Paths are handled wrong on Windows, breaking incremental checkpoints. The bug manifests in errors like ``` org.rocksdb.RocksDBException: Unexpected error for: /C:/Users/ewens/AppData/Local/Temp/... ...-77c716fd2ade/chk-682375462378: The filename, directory name, or volume label syntax is incorrect. ``` The bug was caused by wrong path handling logic on Windows. RocksDB's initial native checkpoint (flush/hardlink) needs to go lo the local filesystem anyways, so we can directly use local path class for that, which does not suffer from cross-platform escaping issues. ## Brief change log - Replace use of `org.apache.flink.core.fs.Path` with `java.nio.file.Path` in RocksDB incremental checkpoint classes. ## Verifying this change This change is already covered by the tests for RocksDB checkpointing. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **yes** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
