pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] 
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378697278
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
 ##########
 @@ -449,7 +450,7 @@ private void cleanUp() {
                        try {
                                r.run();
                        } catch (Exception e) {
-                               firstException = 
ExceptionUtils.firstOrSuppressed(firstException, e);
+                               firstException = 
ExceptionUtils.firstOrSuppressed(e, firstException);
 
 Review comment:
   > the only difference will be in error message and stacktrace.
   
   Isn't that's the whole point of using `firstOrSuppressed` - to have the 
correct exception message? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to