wangyang0918 commented on issue #11070: [FLINK-16013][core] Write and parse 
list config option correctly
URL: https://github.com/apache/flink/pull/11070#issuecomment-585565086
 
 
   @kl0u Thanks for your comments. Moving the converting logic to 
`Configuration#convertToString()` is a better choice. I have updated the PR 
according this.
   
   BTW, i think we could not avoid `instanceof List`. Because the value could 
be any `List`(e.g.`ArrayList`, `LinkedList`, etc.).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to