zhijiangW commented on a change in pull request #7368: [FLINK-10742][network]
Let Netty use Flink's buffers directly in credit-based mode
URL: https://github.com/apache/flink/pull/7368#discussion_r377461190
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -449,6 +486,10 @@ static ErrorResponse readFrom(ByteBuf buffer) throws
Exception {
}
}
}
+
+ static int getMessageHeaderLength(int lengthWithoutFrameHeader)
{
+ return lengthWithoutFrameHeader;
Review comment:
Actually this way is still hacky, the specific message should be aware of
its length, but it is still understood by the upper layer and take a round to
get it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
