aljoscha commented on a change in pull request #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375812980
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -42,10 +44,18 @@
*/
public class SecurityConfiguration {
- private static final List<SecurityModuleFactory> DEFAULT_MODULES =
Collections.unmodifiableList(
- Arrays.asList(new HadoopModuleFactory(), new
JaasModuleFactory(), new ZookeeperModuleFactory()));
+ private static final String DEFAULT_CONTEXT_FACTORY =
DefaultSecurityContextFactory.class.getCanonicalName();
- private final List<SecurityModuleFactory> securityModuleFactories;
+ private static final List<String> DEFAULT_MODULE_FACTORIES =
Collections.unmodifiableList(Arrays.asList(
+ HadoopModuleFactory.class.getCanonicalName(),
+ JaasModuleFactory.class.getCanonicalName(),
+ ZookeeperModuleFactory.class.getCanonicalName()));
+
+ private final String securityContextFactory;
+
+ private final List<String> securityModuleFactories;
+
+ private final Map<String, Object> properties;
Review comment:
if that works, without changing the production code for the test, then yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
