zhijiangW opened a new pull request #11031: [FLINK-15914][checkpointing][metrics] Miss the checkpoint related metrics for the case of two inputs URL: https://github.com/apache/flink/pull/11031 ## What is the purpose of the change When the `StreamTwoInputSelectableProcessor` was introduced before, it forgot adding the checkpoint related metrics in the constructor. But it did not cause any problems, because only the `StreamTwoInputProcessor` actually worked before. After `StreamTwoInputProcessor` is replaced by `StreamTwoInputSelectableProcessor` as now, this bug is exposed and we will not see the checkpoint related metrics for the case of two inputs. The solution is to add these metrics while constructing the `CheckpointBarrierHandler`. ## Brief change log Add the related metrics while constructing the `CheckpointBarrierHandler` for two input cases. Refactor the adding of related metrics for one input in order to reuse/unify the codes. ## Verifying this change Via the job testing ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
