walterddr commented on a change in pull request #10891: 
[FLINK-15561][Security][hotfix] Add Delegation Token checker in 
YarnClusterDescriptor
URL: https://github.com/apache/flink/pull/10891#discussion_r375381727
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -435,9 +436,13 @@ public void killCluster(ApplicationId applicationId) 
throws FlinkException {
                        UserGroupInformation loginUser = 
UserGroupInformation.getCurrentUser();
                        if (loginUser.getAuthenticationMethod() == 
UserGroupInformation.AuthenticationMethod.KERBEROS
                                        && useTicketCache && 
!loginUser.hasKerberosCredentials()) {
-                               LOG.error("Hadoop security with Kerberos is 
enabled but the login user does not have Kerberos credentials");
-                               throw new RuntimeException("Hadoop security 
with Kerberos is enabled but the login user " +
+                               // a delegation token is an adequate substitute 
in most cases
 
 Review comment:
   +1 moving to HadoopUtils makes more sense to me actually - if I understand 
correctly, delegation Token is a hadoop concept; Kerberos official doc seems to 
only contain a guidance on credential delegation: 
https://tools.ietf.org/html/rfc5896.html.
   
   I will make the adjustment accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to