sunhaibotb commented on a change in pull request #10151: [FLINK-14231] Handle the pending processing-time timers to make endInput semantics on the operator chain strict URL: https://github.com/apache/flink/pull/10151#discussion_r373989896
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/CodeGenOperatorFactory.java ########## @@ -43,18 +42,12 @@ public CodeGenOperatorFactory(GeneratedClass<? extends StreamOperator<OUT>> gene @Override public <T extends StreamOperator<OUT>> T createStreamOperator(StreamTask<?, ?> containingTask, StreamConfig config, Output<StreamRecord<OUT>> output) { - return (T) generatedClass.newInstance(containingTask.getUserCodeClassLoader(), + T operator = (T) generatedClass.newInstance(containingTask.getUserCodeClassLoader(), generatedClass.getReferences(), containingTask, config, output); - } - - @Override - public void setChainingStrategy(ChainingStrategy strategy) { - this.strategy = strategy; - } - - @Override - public ChainingStrategy getChainingStrategy() { - return strategy; + if (operator instanceof ProcessingTimeServiceAware) { + ((ProcessingTimeServiceAware) operator).setProcessingTimeService(processingTimeService); + } Review comment: please see the comment: https://github.com/apache/flink/pull/10151#discussion_r373987871 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services