rkhachatryan commented on a change in pull request #10435:
[FLINK-13955][runtime] migrate ContinuousFileReaderOperator to the mailbox
execution model
URL: https://github.com/apache/flink/pull/10435#discussion_r373049762
##########
File path:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTest.java
##########
@@ -217,10 +222,11 @@ public void testFileReadingOperatorWithIngestionTime()
throws Exception {
tester.setProcessingTime(nextTimestamp);
// send the next split to be read and wait until it is
fully read, the +1 is for the watermark.
- tester.processElement(new StreamRecord<>(
- new
TimestampedFileInputSplit(modTimes.get(split.getPath().getName()),
- split.getSplitNumber(),
split.getPath(), split.getStart(),
- split.getLength(),
split.getHostnames())));
+ RunnableWithException runnableWithException = () ->
tester.processElement(new StreamRecord<>(
+ new
TimestampedFileInputSplit(modTimes.get(split.getPath().getName()),
+ split.getSplitNumber(),
split.getPath(), split.getStart(),
+ split.getLength(),
split.getHostnames())));
+ tester.enqueueMail(runnableWithException);
Review comment:
If I understood you correctly, it would introduce tight coupling between the
test and the implementation details (`mailbox`).
And so it won't be compatible with the upcoming FLIP-27 implementation and
the test would have to be rewritten again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
