zentol commented on issue #10944: [FLINK-15739] Fix TypeSerializerUpgradeTestBase on Java 12 URL: https://github.com/apache/flink/pull/10944#issuecomment-579261556 @igalshilman According to Aljoscha they don't have to be on the test classpath at the same time; you need one version to be on _some_ classpath during the setup, the other on _some other_ classpath during the verification. As for the classpath, the test module would exclude the old/new serializers modules from the test classpath via the surefire plugin, but load the jars through a ChildFirstClassloader. @aljoscha That still doesn't quite explain why you'd need multiple modules; are you worried about dependency conflicts? Why would the test module not be able to depend on the uber-old-implementation module? (even then, you could exclude all the stuff you don't need...) You would probably require an additional test module for each serializer (since the implementation module would depend on the main serializer module, but then the test can't be in the main module due to dependency recursion). I'll happily admit that doing "clever" relocations make the test easier to write, but I'm wondering whether a "dumb" isn't more representative of what happens in reality.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
