[ 
https://issues.apache.org/jira/browse/FLINK-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025073#comment-17025073
 ] 

Dawid Wysakowicz commented on FLINK-15771:
------------------------------------------

I am not sure what can we do about it :(

I can't reproduce it locally. I run the test ~100 times and it succeeds all the 
time. It's true we are not strictly enforcing the order, but we are effectively 
running the test with parallelism of 1, which should produce deterministic 
results. We do group by window, but it should nevertheless output in order of 
incoming keys. Unless I am missing something here [~jark]

I agree it might make sense to add some sorting at the end. The problem is we 
cannot add the sorting in the query because it is a streaming query without 
time attributes. This would mean we would have to apply a global sorting on a 
stream which is not possible. We would have to rework the whole structure of 
the test.

I am also not 100% sure what do we actually want to test with this e2e test. If 
we just want to test that dependencies, classloading issues with different 
connectors. We could probably simplify the test. 

> SQLClientKafkaITCase.testKafka failed on Travis
> -----------------------------------------------
>
>                 Key: FLINK-15771
>                 URL: https://issues.apache.org/jira/browse/FLINK-15771
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kafka, Table SQL / Client, Tests
>    Affects Versions: 1.10.0, 1.11.0
>            Reporter: Till Rohrmann
>            Assignee: Dawid Wysakowicz
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.10.0, 1.11.0
>
>
> The end-to-end test {{SQLClientKafkaITCase.testKafka}} failed with
> {code}
> 22:09:36.957 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time 
> elapsed: 129.244 s <<< FAILURE! - in 
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase
> 22:09:36.958 [ERROR] testKafka[2: kafka-version:universal 
> kafka-sql-version:.*kafka.jar](org.apache.flink.tests.util.kafka.SQLClientKafkaITCase)
>   Time elapsed: 45.954 s  <<< FAILURE!
> org.junit.ComparisonFailure: 
> expected:<...-03-12 09:00:00.000,[Bob,This was another warning.,1,Success 
> constant folding.
> 2018-03-12 09:00:00.000,Steve,This was another info.,2],Success constant 
> fo...> but was:<...-03-12 09:00:00.000,[Steve,This was another 
> info.,2,Success constant folding.
> 2018-03-12 09:00:00.000,Bob,This was another warning.,1],Success constant 
> fo...>
>       at 
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase.checkCsvResultFile(SQLClientKafkaITCase.java:226)
>       at 
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase.testKafka(SQLClientKafkaITCase.java:154)
> 22:09:37.287 [INFO] 
> 22:09:37.288 [INFO] Results:
> 22:09:37.288 [INFO] 
> 22:09:37.288 [ERROR] Failures: 
> 22:09:37.288 [ERROR]   
> SQLClientKafkaITCase.testKafka:154->checkCsvResultFile:226 
> expected:<...-03-12 09:00:00.000,[Bob,This was another warning.,1,Success 
> constant folding.
> {code}
> https://api.travis-ci.org/v3/job/641346345/log.txt



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to