dianfu commented on a change in pull request #10913: [FLINK-15636][python] Supports Python UDF in old planner under batch mode URL: https://github.com/apache/flink/pull/10913#discussion_r369424851
########## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/plan/PythonCalcSplitRuleTest.scala ########## @@ -266,4 +266,26 @@ class PythonCalcSplitRuleTest extends TableTestBase { util.verifyTable(resultTable, expected) } + + @Test + def testSplitRuleForBatch(): Unit = { Review comment: I guess we can remove this test case as the split rule is applied for both the streaming and batch plans. The original tests for streaming plans are enough. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services