pnowojski commented on a change in pull request #10151: [FLINK-14231] Handle
the pending processing-time timers to make endInput semantics on the operator
chain strict
URL: https://github.com/apache/flink/pull/10151#discussion_r368980733
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorFactory.java
##########
@@ -65,20 +68,11 @@ public StreamOperator createStreamOperator(StreamTask
containingTask, StreamConf
capacity,
outputMode,
mailboxExecutor);
+
asyncWaitOperator.setProcessingTimeService(processingTimeService);
Review comment:
This should be moved to the constructor.
If an operator already has a factory, it should be using post constructor
`setProcessingTimeService(...)`. The `#setup(...)` method call before is a big
technological debt - intermediate step on migrating the `AsyncWaitOperator`
from `SetupableStreamOperator` to the factory pattern.
True proper solution would be to remove `SetupableStreamOperator` from the
`AsyncWaitOperator`.
Ditto also in other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
