wangyang0918 commented on a change in pull request #10898:
[FLINK-15632][kubernetes] Make zookeeper HA service could work for active
kubernetes integration
URL: https://github.com/apache/flink/pull/10898#discussion_r368556538
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -168,6 +185,13 @@ public String getClusterDescription() {
final String nameSpace =
flinkConfig.getString(KubernetesConfigOptions.NAMESPACE);
flinkConfig.setString(JobManagerOptions.ADDRESS, clusterId +
"." + nameSpace);
+ if
(HighAvailabilityMode.isHighAvailabilityModeActivated(flinkConfig)) {
+
flinkConfig.setString(HighAvailabilityOptions.HA_CLUSTER_ID, clusterId);
Review comment:
We should update the `HA_CLUSTER_ID` since it will be used to contruct the
zk path and ha storage path for the Flink cluster.
Yarn has the similar behavior in
`FlinkYarnSessionCli#applyCommandLineOptionsToConfiguration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
