wangyang0918 commented on a change in pull request #10898: 
[FLINK-15632][kubernetes] Make zookeeper HA service could work for active 
kubernetes integration
URL: https://github.com/apache/flink/pull/10898#discussion_r368290487
 
 

 ##########
 File path: 
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8ClientTest.java
 ##########
 @@ -189,7 +190,10 @@ public void testCreateFlinkMasterDeployment() {
                        jmContainer.getVolumeMounts().get(0).getMountPath());
                assertEquals(FLINK_CONF_FILENAME, 
jmContainer.getVolumeMounts().get(0).getSubPath());
 
-               assertThat(jmContainer.getEnv(), Matchers.contains(new 
EnvVar(FLINK_MASTER_ENV_KEY, FLINK_MASTER_ENV_VALUE, null)));
+               EnvVar masterEnv = new EnvVar(FLINK_MASTER_ENV_KEY, 
FLINK_MASTER_ENV_VALUE, null);
 
 Review comment:
   Make sense. I will put it into a separate commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to