xintongsong commented on issue #10852: [FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate the original intended behavior URL: https://github.com/apache/flink/pull/10852#issuecomment-575161611 Thanks for the review and explanations, @tillrohrmann and @azagrebin . I think `YarnClusterInformationRetriever` sounds to be a really good solution. For having a testing implementation of `YarnClient`, my concern is that we might need to introduce too many unused implementations. And if the Yarn API is extended in later versions, we might need to further extend our testing implementation, or even run into dependency problems of various Hadoop versions. I've updated the PR with the `YarnClusterInformationRetriever` approach. Please take another look.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
