xintongsong opened a new pull request #10834: [FLINK-15530][dist] Replace process memory with flink memory for TMs in default flink-conf.yaml URL: https://github.com/apache/flink/pull/10834 ## What is the purpose of the change This PR replaces `taskmanager.memory.process.size` with `taskmanager.memory.flink.size` for the default `flink-conf.yaml`. It also resolves several yarn deployment problems of using `taskmanager.memory.flink.size`. ## Brief change log - 1c542f583070354ec7eed451653ba86fa14561f1: Disable max vcore validation test cases. - These test cases should have failed already, but is covered by cluster specification memory validation failures. - This PR removes the cluster specification memory validation and uncovers the problems. - We will create separate issues to track the disabled test cases. - 642fcbe8fe13b14c8da0e9a5acf1d5c99c617314: Remove `ClusterSpecification` memory validation. - The validation is already covered by generating `TaskExecutorResourceSpec` in `AbstractContainerizedClusterClientFactory`. - `ClusterSpecification` stores TM memory in MB. The accuracy loss may cause false negative validation failures, especially when process memory is derived from flink memory and is not a integer value of MB. - 96f3e7956b3ac28c96afed20e45bca34cd7ea56e: Hotfix for removing unused env keys. - 294dae71fc791d88801810d178aef13cbdb02649: Hotfix for removing unused `numberOfTaskManagers`. - 14a36328ad3a42d8a15a4797baf7b33107f16160: Hotfix for removing unnecessary overwriting configuration with `ClusterSpecification`. - The `ClusterSpecification` is generated from configuration at the first place. - 1edb31fe2aa2466c3cae6119c799be03bf30ed1f: Unset configured flink size if process size is specified via client options `-tm`. - 78ce3aaf9f756bb27b20e1f51ff57d0ff4143b75: Replace process memory with flink memory in default `flink-conf.yaml`. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
