TisonKun commented on a change in pull request #10658: [FLINK-15359] Remove
unused YarnConfigOptions, Tests, Docs
URL: https://github.com/apache/flink/pull/10658#discussion_r364630402
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
##########
@@ -434,17 +434,6 @@
@Deprecated
public static final String YARN_REALLOCATE_FAILED_CONTAINERS =
"yarn.reallocate-failed";
- /**
- * The maximum number of failed YARN containers before entirely stopping
- * the YARN session / job on YARN.
- *
- * <p>By default, we take the number of initially requested containers.
- *
- * @deprecated in favor of {@code
YarnConfigOptions#MAX_FAILED_CONTAINERS}.
- */
- @Deprecated
- public static final String YARN_MAX_FAILED_CONTAINERS =
"yarn.maximum-failed-containers";
-
Review comment:
Thanks for the explanation. I will push a commit to revert the removal of
`ConfigConstants#YARN_MAX_FAILED_CONTAINERS` and will be careful changes in
`@Public` the next time.
Besides, I'd like to know the reason we turn off japicmp plugin for
`ConfigConstants`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
