KarmaGYZ opened a new pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly URL: https://github.com/apache/flink/pull/10804 ## What is the purpose of the change When using logback it is not possible to start the taskmanager using taskamanger.sh scripts. To fix this issue, we need to make a contract that the calculation result is always outputted in the last line and in specific format. Then, we can fetch and verify it even when the log is redirected to console. ## Brief change log - Introduce a prefix to the calculation result of `BashJavaUtils` class - Fetch the calculation result and ignore side output. - Fail the script when error occurs during calculation. ## Verifying this change 1. Using logback, you could follow [this guide](https://issues.apache.org/jira/browse/FLINK-15488?focusedCommentId=17009653&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17009653) 2. Start a TaskExecutor by `${FLINK_DIR}/bin/taskmanager.sh` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? no
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
