[ 
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009270#comment-15009270
 ] 

ASF GitHub Bot commented on FLINK-2978:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45103827
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
 ---
    @@ -113,7 +117,17 @@ private void respondAsLeader(ChannelHandlerContext 
ctx, Routed routed, ActorGate
                DefaultFullHttpResponse response;
     
                try {
    -                   String result = 
handler.handleRequest(routed.pathParams(), jobManager);
    +                   Map<String, String> params = routed.pathParams();
    --- End diff --
    
    I see, that is a case for query parameters. Is it better to have them all 
in one map, or to simply give the function two maps?


> Integrate web submission interface into the new dashboard
> ---------------------------------------------------------
>
>                 Key: FLINK-2978
>                 URL: https://issues.apache.org/jira/browse/FLINK-2978
>             Project: Flink
>          Issue Type: New Feature
>          Components: Web Client, Webfrontend
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> As discussed in 
> http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8tshpz6r4p2jvx7nrlom7caajrb9s6...@mail.gmail.com%3E,
>  we should integrate job submission from the web into the dashboard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to