tillrohrmann commented on a change in pull request #10717:
[FLINK-15369][runtime] MiniCluster use fixed network / managed memory sizes by
default
URL: https://github.com/apache/flink/pull/10717#discussion_r363256732
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterConfigurationTest.java
##########
@@ -74,4 +78,15 @@ public void
testSchedulerType_notOverriddenIfExistingInConfig() {
JobManagerOptions.SCHEDULER.defaultValue(),
miniClusterConfiguration.getConfiguration().getString(JobManagerOptions.SCHEDULER));
}
+
+ @Test
+ public void testDefaultTaskExecutorMemoryConfiguration() {
+ final MiniClusterConfiguration miniClusterConfiguration = new
MiniClusterConfiguration.Builder().build();
+ final Configuration actualConfiguration =
miniClusterConfiguration.getConfiguration();
+ final Configuration expectedConfiguration =
MiniClusterConfiguration.adjustTaskManagerMemoryConfigurations(new
Configuration());
+
+
assertThat(actualConfiguration.get(TaskManagerOptions.SHUFFLE_MEMORY_MIN),
is(expectedConfiguration.get(TaskManagerOptions.SHUFFLE_MEMORY_MIN)));
+
assertThat(actualConfiguration.get(TaskManagerOptions.SHUFFLE_MEMORY_MAX),
is(expectedConfiguration.get(TaskManagerOptions.SHUFFLE_MEMORY_MAX)));
+
assertThat(actualConfiguration.get(TaskManagerOptions.MANAGED_MEMORY_SIZE),
is(expectedConfiguration.get(TaskManagerOptions.MANAGED_MEMORY_SIZE)));
Review comment:
I would change the assertions to test the actual values because now the test
would also pass if `adjustTaskManagerMemoryConfigurations` did not do anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
