tillrohrmann commented on a change in pull request #10682:
[FLINK-15247][Runtime] Wait for all slots to be free before task executor
services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#discussion_r362823661
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskSubmissionTestEnvironment.java
##########
@@ -124,6 +124,7 @@ private TaskSubmissionTestEnvironment(
this.taskSlotTable = mock(TaskSlotTable.class);
when(taskSlotTable.tryMarkSlotActive(eq(jobId),
any())).thenReturn(true);
when(taskSlotTable.addTask(any(Task.class))).thenReturn(true);
+
when(taskSlotTable.freeAllSlots(any(Throwable.class))).thenReturn(CompletableFuture.completedFuture(null));
Review comment:
Instead of adding mockito logic, I would suggest to extract an interface and
provide a proper testing implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
