[
https://issues.apache.org/jira/browse/FLINK-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006480#comment-15006480
]
ASF GitHub Bot commented on FLINK-2914:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1359
[FLINK-2914] Add missing break Statement in ZKJobGraphStore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 2914_break
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1359
----
commit e54198f479f8366288c432ae77de54b3683416c7
Author: zentol <ches...@apache.org>
Date: 2015-11-16T10:35:28Z
[FLINK-2914] Add missing break Statement in ZKJobGraphStore
----
> Missing break in
> ZooKeeperSubmittedJobGraphStore#SubmittedJobGraphsPathCacheListener#childEvent()
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-2914
> URL: https://issues.apache.org/jira/browse/FLINK-2914
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> case CONNECTION_SUSPENDED:
> LOG.warn("ZooKeeper connection SUSPENDED. Changes to the submitted
> job " +
> "graphs are not monitored (temporarily).");
> case CONNECTION_LOST:
> LOG.warn("ZooKeeper connection LOST. Changes to the submitted job "
> +
> "graphs are not monitored (permanently).");
> break;
> case CONNECTION_RECONNECTED:
> LOG.info("ZooKeeper connection RECONNECTED. Changes to the
> submitted job " +
> "graphs are monitored again.");
> case INITIALIZED:
> LOG.info("SubmittedJobGraphsPathCacheListener initialized");
> break;
> {code}
> For CONNECTION_SUSPENDED and CONNECTION_RECONNECTED, the break statement is
> missing.
> This would result in unrelated event logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
