[ 
https://issues.apache.org/jira/browse/FLINK-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000740#comment-17000740
 ] 

Zhu Zhu commented on FLINK-15345:
---------------------------------

>> When the length of priorExecutions does not exceed the value of the 
>> configuration item jobmanager.execution.attempts-history-size, the attempt 
>> should be equal to the length of priorExecutions

Not sure if there is any logic that relies on this assumption. Is there any 
issue caused by it?

> CurrentExecution and priorExecutions are inconsistent in the test case
> ----------------------------------------------------------------------
>
>                 Key: FLINK-15345
>                 URL: https://issues.apache.org/jira/browse/FLINK-15345
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / REST, Tests
>            Reporter: lining
>            Priority: Minor
>
> When the length of priorExecutions does not exceed the value of the 
> configuration item jobmanager.execution.attempts-history-size, the attempt 
> should be equal to the length of priorExecutions. So [code in 
> JobExceptionsHandlerTest|https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandlerTest.java#L104-L121]
>  and [code in 
> SubtaskCurrentAttemptDetailsHandlerTest|https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/SubtaskCurrentAttemptDetailsHandlerTest.java#L94-L111]
>  are wrong, we need to update the attempt to 0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to