wuchong commented on a change in pull request #10536: [FLINK-15191][connectors
/ kafka]Fix can't create table source for Kafka if watermark or computed column
is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357505503
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableFormatFactoryBase.java
##########
@@ -151,7 +163,9 @@ public static TableSchema deriveSchema(Map<String, String>
properties) {
.orElse(false);
final String timestampKey = SCHEMA + '.' + i + '.' +
ROWTIME_TIMESTAMPS_TYPE;
final boolean isRowtime =
descriptorProperties.containsKey(timestampKey);
- if (!isProctime && !isRowtime) {
+ if (!isProctime
+ && !isRowtime
+ && baseSchema.getTableColumn(i).map(col ->
!col.isGenerated()).orElse(false)) {
Review comment:
Extract the isGenerated flag before if condition?
```java
boolean isGeneratedColumn = properties
.containsKey(SCHEMA + "." + i + "." +
TABLE_SCHEMA_EXPR);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
