KurtYoung commented on a change in pull request #10454: [FLINK-13195][sql-client] Add create(drop) table support for SqlClient URL: https://github.com/apache/flink/pull/10454#discussion_r354683491
########## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java ########## @@ -428,6 +485,12 @@ private void initializeTableEnvironment() { modules.forEach(tableEnv::loadModule); } + if (catalogManager != null) { + registerFunctions(); + // No need to register the catalogs info if already inherit from the same session. + return; Review comment: step 7 can't be skipped? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services