TisonKun opened a new pull request #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408 ## What is the purpose of the change Add an interface `JobListener` that can be registered by users to get notification when specific job status changed. cc @kl0u @aljoscha @zjffdu Here is one design decision I have to point out and discuss with you. If we pass `JobClient` `onJobSubmitted`, it brings several extra overhead 1. User should not call `JobClient#close` on the passed `JobClient` since it's handled by `execute` or the caller of `executeAsync` 2. `executeAsync` should return after `onJobSubmitted` called; otherwise if user calls `execute` the passed `JobClient` possibly closed concurrently. 3. User should never invoke blocking method in `onJobSubmitted` since it would block the return of `executeAsync` @zjffdu if you're sure the user case is get `JobID` `onJobSubmitted`, we can simply the concurrent/execution model quite a lot. ## Verifying this change Dedicate unit tests `JobListenerTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes, new user-facing API `JobListener` and its registering & removal methods in env) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (JavaDocs, later on document site)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
