openinx commented on a change in pull request #10270: [FLINK-14672][sql-client]
Make Executor stateful in sql client
URL: https://github.com/apache/flink/pull/10270#discussion_r349448931
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -111,71 +113,56 @@
*/
public class ExecutionContext<ClusterID> {
- private final SessionContext sessionContext;
- private final Environment mergedEnv;
+ private final Environment environment;
private final ClassLoader classLoader;
- private final Map<String, Module> modules;
- private final Map<String, Catalog> catalogs;
- private final Map<String, TableSource<?>> tableSources;
- private final Map<String, TableSink<?>> tableSinks;
- private final Map<String, UserDefinedFunction> functions;
+
private final Configuration flinkConfig;
private final Configuration executorConfig;
private final ClusterClientFactory<ClusterID> clusterClientFactory;
private final ExecutionConfigAccessor executionParameters;
private final ClusterID clusterId;
private final ClusterSpecification clusterSpec;
- public ExecutionContext(Environment defaultEnvironment, SessionContext
sessionContext, List<URL> dependencies,
- Configuration flinkConfig, Options
commandLineOptions, List<CustomCommandLine> availableCommandLines) throws
FlinkException {
- this(defaultEnvironment, sessionContext, dependencies,
flinkConfig, new DefaultClusterClientServiceLoader(), commandLineOptions,
availableCommandLines);
+ private TableEnvironment tableEnv;
+ private ExecutionEnvironment execEnv;
+ private StreamExecutionEnvironment streamExecEnv;
+ private Executor executor;
+
+ public ExecutionContext(
+ Environment environment,
Review comment:
I've set the checksytle in my ide, seems the Selection-format makes the
indent happen again. Let me check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
