wuchong commented on issue #10213: [FLINK-12846][table-common] Carry primary key information in TableSchema URL: https://github.com/apache/flink/pull/10213#issuecomment-554744688 Thanks @dawidwys for the reviewing. I agree with that the concepts of primary key on source/sink should be discussed and accepted publicly. But the background of this issue is that we would like to support more optimizations for TPC-DS where the sources have primary key information in Hive metastore. So we would like to only expose the primary key interface to `CatalogTable`, to let the Hive catalog pass the primary key information which is defined by Hive DDL to Flink. If a primary key is defined on Flink DDL or `TableSource#getTableSchema` or `TableSink#getTableSchema`, an unsupported exception will be thrown. In this way, I think the primary key concepts is simple and clear which is similar to [Hive's definition](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL). But I'm not sure whether this still requires a FLIP. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
