docete opened a new pull request #10208: [FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils pull-in and fix datetime casting problem URL: https://github.com/apache/flink/pull/10208 ## What is the purpose of the change This DateTimeUtils was pulled in in FLINK-7235. And now both legacy planner and blink planner hold a copy of DateTimeUtils which make it very difficult to maintain. On the other hand, Apache calcite keeps carrying forward and fix some bugs. IMO it's time to remove DateTimeUtils pull-in. The impact to legacy planner: 1) toString of java.sql.Timestamp/Date considers Gregorian cutover which should be ignore. CALCITE-1884 has ignored the cutover, so CAST timestamp/date to STRING should ignore it too. 2) CALCITE-3199 is not merged in avatica-1.15.0 (we currently depends on) which should be fixed by ourself. The impact to blink planner: 1) SimpleDateFormat(used by casting timestamp to string and vice-versa) considers Gregorian cutover which should be ignore. 2) CALCITE-3199 is not merged in avatica-1.15.0 ## Brief change log - 8572c6c2 removes DateTimeUtils from legacy planner and blink planner - cb8a6948 and b5fed1d1 fix legacy planner - 68acfbf5 and 6c24e992 fix blink planner ## Verifying this change This change is already covered by existing tests, such as *ScalarFunctionsTest*, *TemporalTypesTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
