GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let
YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r346290211
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnJobClusterEntrypoint.java
##########
@@ -61,10 +65,20 @@ protected String getRPCPortRange(Configuration
configuration) {
}
@Override
- protected DefaultDispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
+ protected DefaultDispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration)
throws IOException {
+ final YarnConfigOptions.UserJarInclusion userJarInclusion =
configuration
+ .getEnum(YarnConfigOptions.UserJarInclusion.class,
YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR);
+ checkState(
+ userJarInclusion !=
YarnConfigOptions.UserJarInclusion.DISABLED ||
tryFindUserLibDirectory().isPresent(),
+ String.format("The %s is set to %s. But the usrlib
directory does not exist.",
Review comment:
It's better not to use `String.format` to avoid eager string creation. There
is an overload for `checkState`:
```
public static void checkState(boolean condition,
@Nullable String errorMessageTemplate,
@Nullable Object... errorMessageArgs)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
