zjffdu commented on a change in pull request #10104: [FLINK-14629][client] 
Refactor ScalaShellRemote(Stream)Environment to simplify inheritance
URL: https://github.com/apache/flink/pull/10104#discussion_r346135396
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
 ##########
 @@ -528,8 +529,9 @@ public static void deleteExtractedLibraries(List<File> 
tempLibraries) {
 
        private static void checkJarFile(URL jarfile) throws 
ProgramInvocationException {
 
 Review comment:
   Do we still need this checkJarFile method ? It looks like we use call 
`JarUtils.checkJarFile` directly ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to