wuchong commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r345662571
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/types/LogicalTypeDataTypeConverter.java
##########
@@ -98,6 +101,12 @@ protected LogicalType defaultMethod(LogicalType
logicalType) {
} else if (typeInfo instanceof
BigDecimalTypeInfo) {
BigDecimalTypeInfo decimalType =
(BigDecimalTypeInfo) typeInfo;
return new
DecimalType(decimalType.precision(), decimalType.scale());
+ } else if (typeInfo instanceof
LegacyLocalDateTimeTypeInfo) {
Review comment:
The newly introduced `LegacyLocalDateTimeTypeInfo` is wired. In theory, we
don't need such things unless somewhere converting DataType to TypeInformation
and back again. I think we should find out the root cause why we need this and
create JIRA to fix the root cause. And add comments on these classes with the
JIRA id.
Otherwise, we don't know how to remove these temporary code in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
