JingsongLi commented on issue #10183: [FLINK-14743][table-blink] Optimize 
BaseRowSerializer to use Projection instead of switch
URL: https://github.com/apache/flink/pull/10183#issuecomment-553726864
 
 
   > -1, I don't think any code generation logic should happen during runtime.
   
   How about move the generation of `GeneratedProjection` to the constructor of 
`BaseRowSerializer`? Is that what you mean? Or BaseRowSerializer just can not 
see `ProjectionCodeGenerator`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to