KarmaGYZ commented on a change in pull request #10079: [FLINK-14594] Fix 
matching logics of ResourceSpec/ResourceProfile/Resource considering double 
values
URL: https://github.com/apache/flink/pull/10079#discussion_r342942576
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
 ##########
 @@ -68,7 +71,8 @@
        public static final String GPU_NAME = "GPU";
 
        /** How many cpu cores are needed, use double so we can specify cpu 
like 0.1. */
-       private final double cpuCores;
+       @Nullable // can be null only for UNKNOWN
 
 Review comment:
   Merge this comment with the sentence above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to