zhijiangW commented on a change in pull request #10097: 
[FLINK-14603][runtime]Notify the potential buffer consumers if the size of 
LocalBufferPool has been expanded.
URL: https://github.com/apache/flink/pull/10097#discussion_r342935391
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
 ##########
 @@ -357,9 +355,7 @@ public void lazyDestroy() {
                }
 
                // notify the potential blocking request thread
 
 Review comment:
   we could remove this comment and add it in the javadoc of the method 
`mayNotifyAvailable`, then it can be reused by all the calls.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to