wsry opened a new pull request #10097: [FLINK-14603][runtime]Notify the 
potential buffer consumers if the size of LocalBufferPool has been expanded.
URL: https://github.com/apache/flink/pull/10097
 
 
   ## What is the purpose of the change
   Currently, when the size of ```LocalBufferPool``` is expended by 
```LocalBufferPool#setNumBuffers``` and there are segments available in the 
global ```NetworkBufferPool```, we may failed to notify the potential buffer 
consumers which are waiting for the ``LocalBufferPool`` to be available. This 
is a potential regression compared to the previous implementation in which the 
blocking request thread will wake itself up actively and request available 
buffers form the global pool.
   
   The purpose of this PR is to fix the regression by notify the potential 
buffer consumers when the size of ```LocalBufferPool``` is expended.
   
   ## Brief change log
   
     - The potential buffer consumers are notified when the size of 
```LocalBufferPool``` is expended.
     - Test case ```LocalBufferPoolTest#testIsAvailableOrNot``` is enhanced to 
cover the scenario.
   
   
   ## Verifying this change
   
   This change is verified by enhancing the existing test case 
```LocalBufferPoolTest#testIsAvailableOrNot```.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to