JingsongLi commented on a change in pull request #10035: [FLINK-14080][table-planner-blink] Introduce DateTime as internal representation of TIMESTAMP_WITHOUT_TIME_ZONE URL: https://github.com/apache/flink/pull/10035#discussion_r341461581
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/DateTimeTypeInfo.java ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.typeutils; + +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.table.dataformat.DateTime; + +import java.util.Arrays; + +/** + * TypeInfomation of {@link DateTime}. + */ +public class DateTimeTypeInfo extends TypeInformation<DateTime> { + + public static DateTimeTypeInfo of(int precision) { + return new DateTimeTypeInfo(precision); + } + + private final int precision; + + protected DateTimeTypeInfo(int precision) { + this.precision = precision; + } + + @Override + public boolean isBasicType() { + return true; + } + + @Override + public boolean isTupleType() { + return false; + } + + @Override + public int getArity() { + return 1; + } + + @Override + public int getTotalFields() { + return 1; + } + + @Override + public Class<DateTime> getTypeClass() { + return DateTime.class; + } + + @Override + public boolean isKeyType() { + return true; + } + + @Override + public TypeSerializer<DateTime> createSerializer(ExecutionConfig config) { + return new DateTimeSerializer(precision); + } + + @Override + public String toString() { + return String.format("DateTime(%d)", precision); + } + + @Override + public boolean equals(Object obj) { + if (!(obj instanceof DateTimeTypeInfo)) { + return false; + } + + DateTimeTypeInfo that = (DateTimeTypeInfo) obj; + return this.precision == that.precision; + } + + @Override + public int hashCode() { + int h0 = this.getClass().getCanonicalName().hashCode(); + return Arrays.hashCode(new int[]{h0, precision}); Review comment: `Objects.hash` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
