zhijiangW commented on a change in pull request #9993: [FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting with LocalBufferPool. URL: https://github.com/apache/flink/pull/9993#discussion_r341436098
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ########## @@ -231,25 +230,39 @@ private BufferBuilder toBufferBuilder(MemorySegment memorySegment) { @Nullable private MemorySegment requestMemorySegment(boolean isBlocking) throws InterruptedException, IOException { + if (!isBlocking) { + return requestMemorySegment(); + } else { + MemorySegment segment = null; Review comment: nit: remove `=null` when remove `if` condition as below. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services