KurtYoung commented on a change in pull request #9994: [FLINK-14322][table-api]
Add watermark information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r341434266
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -343,13 +396,30 @@ public Builder field(String name, TypeInformation<?>
typeInfo) {
return field(name, fromLegacyInfoToDataType(typeInfo));
}
+ /**
+ * Specifies the previously defined field as an event-time
attribute and specifies the watermark strategy.
+ *
+ * @param rowtimeAttribute the field name as a rowtime
attribute, can be a nested field using dot separator.
+ * @param watermarkStrategy the watermark strategy expression
+ */
+ public Builder watermark(String rowtimeAttribute,
ResolvedExpression watermarkStrategy) {
Review comment:
The problem is there are two major types of `Expression` now, one is
unresolved and another one is resolved. We will only have interface (like Java
DSL style) for unresolved expression. But the issue is we need some other
information which only accessible from resolved one, like data types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
