TisonKun commented on a change in pull request #9974: 
[FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from 
CommandLine
URL: https://github.com/apache/flink/pull/9974#discussion_r340416816
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -709,22 +730,9 @@ private ApplicationReport startAppMaster(
                        systemShipFiles.add(file.getAbsoluteFile());
                }
 
-               //check if there is a logback or log4j file
-               File logbackFile = new File(configurationDirectory + 
File.separator + CONFIG_FILE_LOGBACK_NAME);
-               final boolean hasLogback = logbackFile.exists();
-               if (hasLogback) {
-                       systemShipFiles.add(logbackFile);
-               }
-
-               File log4jFile = new File(configurationDirectory + 
File.separator + CONFIG_FILE_LOG4J_NAME);
-               final boolean hasLog4j = log4jFile.exists();
-               if (hasLog4j) {
-                       systemShipFiles.add(log4jFile);
-                       if (hasLogback) {
-                               // this means there is already a logback 
configuration file --> fail
-                               LOG.warn("The configuration directory ('" + 
configurationDirectory + "') contains both LOG4J and " +
-                                               "Logback configuration files. 
Please delete or rename one of them.");
-                       }
+               final String logConfigFilePath = 
configuration.getString(YarnConfigOptions.APPLICATION_LOG_CONFIG_FILE);
 
 Review comment:
   @GJL do you run in session mode or per-job mode?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to